Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address fix-lint target problem not respecting ignore comments #255

Merged
merged 5 commits into from
Jul 7, 2021
Merged

Address fix-lint target problem not respecting ignore comments #255

merged 5 commits into from
Jul 7, 2021

Conversation

fmigneault
Copy link
Collaborator

This is a hack around issue described in PyCQA/pycodestyle#996

@fmigneault fmigneault added ci/tests Tests of the package and features ci/operations Related to CI operations (actions, execution, install, builds, etc.) labels May 13, 2021
@fmigneault fmigneault self-assigned this May 13, 2021
@github-actions github-actions bot added ci/doc Issue related to documentation of the package feature/CWL Issue related to CWL support feature/db Related to database or datatype manipulation. feature/oas Issues related to OpenAPI specifications. process/workflow Related to a Workflow process. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support labels May 13, 2021
@codecov
Copy link

codecov bot commented May 13, 2021 •
edited
Loading

Codecov Report

Merging #255 (7afde6f) into master (94f0f3f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   72.17%   72.17%           
=======================================
  Files          61       61           
  Lines        9409     9409           
  Branches     1414     1414           
=======================================
  Hits         6791     6791           
+ Misses       2232     2231    -1     
- Partials      386      387    +1
Impacted Files Coverage Δ
weaver/datatype.py 62.03% <ø> (ø)
weaver/processes/wps_workflow.py 0.00% <ø> (ø)
weaver/store/mongodb.py 62.60% <ø> (ø)
weaver/wps/service.py 76.62% <ø> (ø)
weaver/wps_restapi/colander_extras.py 77.32% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94f0f3f...7afde6f. Read the comment docs.

@fmigneault fmigneault requested a review from dbyrns July 6, 2021 20:00
@fmigneault fmigneault merged commit e1aa0a8 into master Jul 7, 2021
@fmigneault fmigneault deleted the fix-lint-ignore-comments branch July 7, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyrns dbyrns dbyrns approved these changes

Assignees

@fmigneault fmigneault

Labels
ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/CWL Issue related to CWL support feature/db Related to database or datatype manipulation. feature/oas Issues related to OpenAPI specifications. process/workflow Related to a Workflow process. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmigneault @dbyrns